Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should't the foundation.css build process depend on settings? #9396

Merged
merged 3 commits into from
Dec 1, 2016

Conversation

karland
Copy link

@karland karland commented Nov 20, 2016

foundation.scss pulls in all files from under /scss/, but ignores the settings/settings.scss. As a result foundation.scss uses the !default values instead of the values from the settings.scss. I discovered this behaviour when I was testing something and a change in the settings did not change the resulting foundation.css.

@brettsmason
Copy link
Contributor

@andycochran @ncoden @kball does this look OK to you?
Makes sense to me.

@ncoden
Copy link
Contributor

ncoden commented Nov 29, 2016

Well... /settings/settings.scss is automatically generated by the gulp deploy:settings task. Because of deploy is based on build, we cannot use /settings/settings.scss in build:sass.

I think /settings/settings.scss is intended to be copied by the user for its own sass project. I agree the file paht and name is not clear about this purpose.

@kball
Copy link
Contributor

kball commented Nov 29, 2016

Hmm... I think this may not play nicely with setting things up in an app or other location, where we typically have you include settings and then the items you want to include... letting you move settings to wherever you want in your own app structure without mucking with the library code itself... Not saying that is the ideal setup, but I think this seemingly small change would actually have cascading impacts on existing sites and apps

@karland
Copy link
Author

karland commented Nov 29, 2016

I wasn't sure about the impact of this change, so I put a questionmark at the end of this PR. The docs are pretty clear about how to use the _settings.scss:

http://foundation.zurb.com/sites/docs/sass.html

I can see @kball's point. If a user has included a mysettings.scss its values would be overriden by a following _settings.scss.

If you want, we could put something like this in foundation.scss:

// Settings
// import your own `settings` here or 
// import and modify the default settings through
// @import "settings/settings";

If you want to leave everything as is, I am happy for this PR to be closed.

Copy link
Contributor

@ncoden ncoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kball kball merged commit 6612f46 into foundation:develop Dec 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants